fix: sdcore_config interface tests #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested changes
Aug 27, 2024
| t.assert_schema_valid() | ||
| assert state_out.unit_status.name == 'active' | ||
| t.run("sdcore-config-relation-created") | ||
| t.assert_relation_data_empty() |
There was a problem hiding this comment.
this looks more like a test_no_data_on_created
|
|
||
|
|
||
| t.run('sdcore-config-relation-joined') | ||
| t.assert_relation_data_empty() |
There was a problem hiding this comment.
surprised this would pass, since you are putting some data in the input state. Is the charm supposed to delete the data? If so, rename the test to something more explicit or add some comments to explain what's going on.
| @@ -5,33 +5,17 @@ | |||
| from scenario import Relation, State | |||
|
|
|||
|
|
|||
| def test_state_active_on_joined(): | |||
| def test_no_data_on_joined(): | |||
There was a problem hiding this comment.
there should be a 'happy-path' test in here too, one where you t.assert_schema_valid().
|
The current solution for tests does not fit our need. We will explore how to do these tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdcore_configinterface tests are failing. This PR together with the following fixes it: